Skip to content

SCRUM-5881 add gene synonyms to allele search doc#1554

Merged
oblodgett merged 4 commits intostagefrom
SCRUM-5881
Apr 6, 2026
Merged

SCRUM-5881 add gene synonyms to allele search doc#1554
oblodgett merged 4 commits intostagefrom
SCRUM-5881

Conversation

@cmpich
Copy link
Copy Markdown
Contributor

@cmpich cmpich commented Apr 6, 2026

No description provided.

@cmpich cmpich requested a review from a team as a code owner April 6, 2026 14:02
@claude
Copy link
Copy Markdown

claude bot commented Apr 6, 2026

Code Review: LGTM

This is a clean, minimal change. The geneSynonyms field was already defined in the ES mapping (Mapping.java:96), search helper (SearchHelper.java:186), indexer cache (IndexerCache.java:33,101), and searchable item document (SearchableItemDocument.java:78). This PR fills in the missing piece by:

  1. Adding the geneSynonyms field (Set<String>) to AlleleSearchResultDocument — type matches the existing field in SearchableItemDocument.
  2. Populating it in AlleleSearchResultConverter from AlleleSummaryDocument, following the same null/empty guard pattern used by all surrounding fields.
  3. Bumping the curation dependency to v0.47.31 (which presumably adds getGeneSynonyms() to AlleleSummaryDocument).

No issues found.

@oblodgett oblodgett enabled auto-merge April 6, 2026 17:20
@oblodgett oblodgett merged commit 4fcede6 into stage Apr 6, 2026
5 checks passed
@oblodgett oblodgett deleted the SCRUM-5881 branch April 6, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants